-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow API owner to select one from several configured proxies #1869
Comments
Interested |
Open Question: Need to consider the scenario when owner wishes to switch from one proxy to another...Alert message? |
@marla-singer Could you take this task? |
@bajiat yes, take it. |
@marla-singer Great! Can you please estimate the task in days? |
@bajiat Well, I'm not sure, maybe 2-3 days.
Is it essential to notice user in process switching? Can it be simply static sentence like: |
@marla-singer Are you talking about the owner seeing the progress that the proxy has been switched to another one? I think there a simple feedback dialogue would be good. When the process is done an confirmation dialogue as well. However, I think API users should be notified about the change because they would see a broken link in the API profile page |
I think the first step is to warn the owner that they are making a breaking change (from the point of view of API users). We don't have a notification feature in APInf yet, but notifying the users after proxy has been changed could be considered part of it, when we build one. |
Alert message when API owner tries to switch proxy: |
@Nazarah Yes, i think, we will show the name as hard code like "Current proxy is apiUmbrellaName" or something that. |
@Nazarah The current task is about selecting from more than one API Umbrella proxies. So the in the Select Proxy menu you should be able to somehow differentiate between the different API Umbrella proxies in some way. So the selection does not happen between different proxy types, but between different instances of API Umbrella. |
@bajiat It doesn't matter, it's just the names. Anyway the values for dropdown list will be taken from collections. |
Use the standard Boot Strap alert popup to display when user want to switch a save a different proxy. This refers to wireframe picture 4. |
@bajiat Don't have any answers for this question. So I don't know what to do? Save these data or delete |
@bajiat Another open issue: What behaviour is expected if user select one proxy in list, save settings then select the first item "Select ... " ? Now I hide the form. I'm confused 😕 |
Another case: |
@marla-singer These might not be the same users. An API owner is not necessarily an admin. But still it is possible than a user with admin rights might remove a proxy that has connected API backends. The first thing to do is to warn and make sure there it at least one confirmation before the proxy is removed. Could we potentially give a count of connected proxy backends? "You are about to remove a proxy that has 57 proxy backends connected to it. Removing proxy will mean that API calls to any of the connected API backends will break." This is not part of your task, though. I will create a follow-up issue for changing proxy settings. |
What if you warn first (text suggested by Nazia) and ask for a confirmation: "Do you really want to change the proxy?" |
If user makes a concious decision after being warned, I would say we need to delete from API Umbrella. Ping @brylie |
Yes, delete the backend from the first proxy. Make sure the owner understands the potential side-effects by showing an alert. It is the owners' responsibility to consider and communicate changes to the API users. |
Any time the proxy is changed, and the changes are saved locally:
Note: selecting the 'Select a Proxy' option from the dropdown and clicking save is functionally the same as changing to a different proxy. |
If there is more than one API Umbrella proxy defined for deployment, allow the API owner to select one of them in the Proxy backend settings.
Definition of done
Open issues: If owner changes the proxy, do we need to delete the proxy backend from the original proxy? Users will have a broken link, is it our responsibility to notify or is it owner's responsibility to warn the users?
Wireframes
In API profile Proxy tab, a dropmenu would appear depending on if there are more than 1 proxy available for selection.
Open question: in case of only one proxy avialable, should we show the name as hard coded?
On selecting a specific proxy, associated fields for that proxy would be populated. In the case for only one available proxy, the fields can appear instantly Proxy tab is selected for viewing:
The text was updated successfully, but these errors were encountered: