Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version number empty in About #1910

Closed
bajiat opened this issue Nov 9, 2016 · 3 comments
Closed

Version number empty in About #1910

bajiat opened this issue Nov 9, 2016 · 3 comments
Assignees
Labels

Comments

@bajiat
Copy link
Contributor

bajiat commented Nov 9, 2016

The Apinf version number in About window is empty on staging (i.e. release 0.34), even though the about.html in master contains a version number (0.34).

about window release empty

@brylie brylie self-assigned this Nov 10, 2016
@brylie brylie added ready and removed planning labels Nov 10, 2016
@brylie
Copy link
Contributor

brylie commented Nov 10, 2016

It turns out that the package.json file is replaced when we build the tool. Not only that, but when we deploy the platform, the working directory changes, so proces.env.PWD returns the wrong directory.

Changes needed may include:

  • use process.cwd() to get current working directory
  • determining how to retain pachage.json, or at least the project version number, when building for production

@brylie
Copy link
Contributor

brylie commented Nov 10, 2016

In the short term, we should probably revert this feature. That will mean updating the version number in two files, for each release:

  • package.json
  • .../about.html

@jykae jykae self-assigned this Nov 17, 2016
@jykae
Copy link
Contributor

jykae commented Nov 17, 2016

Assigned by @bajiat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants