Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete translation of 'Branding' page in Suomi view #1955

Closed
saralavanip opened this issue Nov 25, 2016 · 5 comments
Closed

Incomplete translation of 'Branding' page in Suomi view #1955

saralavanip opened this issue Nov 25, 2016 · 5 comments
Assignees
@bajiat
Labels
bug

Comments

@saralavanip
Copy link
Contributor

saralavanip commented Nov 25, 2016 •
edited by bajiat
Loading

Steps

  1. Visit https://staging.apinf.io
  2. Go to language bar and select 'Suomi'
  3. Login as admin
  4. Go to 'Branding'

Findings

Incomplete translation of 'Branding' page in Suomi view.

  • Text field titles, button title text for 'Upload cover photo' are in English language

Screenshot

suomi_branding_view_english_text
@saralavanip saralavanip mentioned this issue Nov 25, 2016
Closed
8 tasks
@bajiat bajiat added the backlog label Nov 28, 2016
@saralavanip
Copy link
Contributor Author

@bajiat , Suomi views of 'Sign Up' and 'Sign In' pages are not translated as well.

Screenshots:
suomi_view_signup_page

suomi_view_signin_page

@bajiat
Copy link
Contributor

bajiat commented Dec 21, 2016

I assume that there are no i18n tags for the missing branding texts, because they were not included in the translation round that was just completed. Check at least the following UI strings:

  • Upload cover photo (button)
  • Colors (panel title)
  • Primary (field title)
  • Primary text (field title)
  • Social media (panel title)

@bajiat bajiat added ready and removed backlog labels Jan 4, 2017
@bajiat
Copy link
Contributor

bajiat commented Jan 9, 2017

@manzapanza I'm unassigning you since you have already added the missing i18n tags and your PR was closed.

This issue can be completed in next translation round.

@bajiat bajiat assigned bajiat and unassigned manzapanza Jan 9, 2017
@bajiat bajiat added planning and removed ready labels Jan 9, 2017
@brylie brylie added ready and removed planning labels Jan 10, 2017
@bajiat bajiat added planning and removed ready labels Jan 19, 2017
@bajiat
Copy link
Contributor

bajiat commented Jan 30, 2017

Translation round completed. To be verified from nightly.

@bajiat
Copy link
Contributor

bajiat commented Feb 1, 2017

Verified in nightly, all strings now have a Finnish translation. Closing as resolved

@bajiat bajiat closed this as completed Feb 1, 2017
@bajiat bajiat removed the planning label Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bajiat bajiat

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brylie @manzapanza @bajiat @saralavanip