Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Proxy form and Edit proxy from don't have translation #2010

Closed
marla-singer opened this issue Feb 3, 2017 · 5 comments
Closed

Add Proxy form and Edit proxy from don't have translation #2010

marla-singer opened this issue Feb 3, 2017 · 5 comments
Assignees
@bajiat @marla-singer
Labels
bug i18n/l10n
Milestone
Sprint 37

Comments

@marla-singer
Copy link
Contributor

marla-singer commented Feb 3, 2017 •
edited by bajiat

Proxy page -> Add proxy button OR Proxy page -> Edit button
joxi_screenshot_1486123311039
joxi_screenshot_1486123311039 1
joxi_screenshot_1486123311039 2
@bajiat
Copy link
Contributor

bajiat commented Feb 6, 2017

@marla-singer Are the strings included in the English i18n file?

@marla-singer
Copy link
Contributor Author

@bajiat Checked it. Nope, the are not.

@marla-singer
Copy link
Contributor Author

@bajiat I wonder do fields "URL", "API key", "auth token" and "elasticSearch" need a translation?

@marla-singer
Copy link
Contributor Author

@bajiat Interested

@bajiat bajiat self-assigned this Feb 20, 2017
@bajiat
Copy link
Contributor

bajiat commented Feb 20, 2017

@marla-singer There should be i18n tags for each of them and the person translating would choose whether to use the English term or to translate.

@marla-singer marla-singer mentioned this issue Feb 20, 2017
Merged
@marla-singer marla-singer added this to the Sprint 37 milestone Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bajiat bajiat

@marla-singer marla-singer

Labels
bug i18n/l10n
Projects
None yet
Milestone
Sprint 37
Development

No branches or pull requests
3 participants
@bajiat @marla-singer @matleppa