Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow API owner to add oembed content for an API #2035

Closed
7 tasks
bajiat opened this issue Feb 6, 2017 · 10 comments
Closed
7 tasks

Allow API owner to add oembed content for an API #2035

bajiat opened this issue Feb 6, 2017 · 10 comments
Assignees
Milestone

Comments

@bajiat
Copy link
Contributor

bajiat commented Feb 6, 2017

From @bajiat on December 13, 2016 12:3

Related to #16

Todo

  • permissions
  • related media (show/hide)

Definition of done

  • API owner can find a button or similar to add content to API profile.
  • Pressing the button opens a form or modal to add the necessary fields (e.g. link, title, description) for the content
  • The content of the form is stored in a collection.
  • When there is no content, only the owner sees the panel with the button that allows to add the oembed content. (In other words, hide the block if there is not content and user is not manager of current API or admin.)
  • Only the API owner can delete and edit each oembed object.

Open issue: attribution information (added by and/or original author)

Wireframe

  1. On API Profile detail page, a button for adding Oembd content will appear on the Oembd Pane.
    oembdadd
    oembdadd

  2. On clicking the button, a dialogue would appear with necessary fields to add a new Oembd contents.
    Fields included: Name, URL, Description, Preview checkbox (checking this would show in which platform the original content is added. e.g. Youtube, Twitter, Wordpress, etc.
    oembdadddom

Copied from original issue: Digipalvelutehdas/APIKA#127

@bajiat
Copy link
Contributor Author

bajiat commented Feb 6, 2017

From @Nazarah on January 3, 2017 6:23

@bajiat @brylie : I created low fidelity design as part of issue #83, and there I also included the design idea of adding oembd content. I am adding those wireframes here. The wireframes are based on card components of bootstrap:
https://v4-alpha.getbootstrap.com/components/card/
when you finalize the design, I can make high fidelity wireframes and post them there.

@bajiat
Copy link
Contributor Author

bajiat commented Feb 6, 2017

From @Nazarah on January 9, 2017 7:48

Alternate design suggestions
Designed this feature as part of issue #83, so adding the associated wireframes with this.

  1. The Add oembd feature appears as a card in the API profile view.
    Below that cards appear a group of added contents with their previews
    apiprofile1

mockup_2

  1. On clicking Add button, a dialogue/form would appear on foreground to add a new content.
    mockup

  2. On clicking Add, the newly added content appears as a card on the top of the oembd content card groups. In Addition to the given information in the add form, the card also shows who added the content and what time the content was added.

@bajiat
Copy link
Contributor Author

bajiat commented Feb 6, 2017

"Add an oembd content" should be renamed to be less technical. If you want, you can add a text that explains user that this adds embedded content that user can click and view in the original source. Give examples of content types (blog posts, videos, presentations)

@bajiat
Copy link
Contributor Author

bajiat commented Feb 6, 2017

From @Nazarah on January 10, 2017 16:14

@bajiat added the suggested changes to wireframes. Please have a look and verify

@bajiat
Copy link
Contributor Author

bajiat commented Feb 6, 2017

@Nazarah The changes are looking ok to me. Just one thing to nitpick about: the title of the section "Embedded Contents". In this meaning, the word "content" is an incountable. So keep also the title of section in singular: "Embedded Content"

@bajiat
Copy link
Contributor Author

bajiat commented Feb 6, 2017

From @Nazarah on January 15, 2017 3:49

Sorry for missing the text modification while creating the wireframe. Added the changes and uploaded the wireframe. Closing the issue #145

@bajiat
Copy link
Contributor Author

bajiat commented Feb 6, 2017

From @snittoor on February 6, 2017 3:24

@bajiat : interested in this.

@bajiat
Copy link
Contributor Author

bajiat commented Feb 6, 2017

From @Nazarah on February 6, 2017 8:18

I will need to add an extra wireframe for the case when API owner has not yet added any Oembed content.

@bajiat
Copy link
Contributor Author

bajiat commented Feb 6, 2017

@matleppa @jawidahmadi To be assigned to you.

@bajiat bajiat added ready and removed planning labels Feb 6, 2017
@bajiat bajiat added this to the Sprint 36 milestone Feb 6, 2017
@matleppa matleppa added in progress and removed ready labels Feb 8, 2017
@jawidahmadi
Copy link
Contributor

@brylie ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants