Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy path validation blocks adding huuto.net API #2152

Closed
kyyberi opened this issue Feb 20, 2017 · 4 comments
Closed

Proxy path validation blocks adding huuto.net API #2152

kyyberi opened this issue Feb 20, 2017 · 4 comments
Assignees
Milestone

Comments

@kyyberi
Copy link

kyyberi commented Feb 20, 2017

As a real world example, I tried to add huuto.net API to catalog and add root of the API to proxy. According to huuto.net API documentation, their root is "/1.1/". http://dev.huuto.net/methods.html#root

kuvakaappaus 2017-02-20 18-53-46

kuvakaappaus 2017-02-20 18-57-18

@kyyberi kyyberi added the bug label Feb 20, 2017
@kyyberi kyyberi changed the title Proxy path validation blocks adding huto.net API Proxy path validation blocks adding huuto.net API Feb 20, 2017
@bajiat
Copy link
Contributor

bajiat commented Feb 21, 2017

@brylie Please verify the error and see where the problems lies?

@brylie
Copy link
Contributor

brylie commented Feb 21, 2017

It looks like we just need to allow '.' character in our API/Proxy base path regular expressions.

@brylie
Copy link
Contributor

brylie commented Feb 21, 2017

We can use the Wikipedia section on types of URL characters to guide our regex design.

@brylie
Copy link
Contributor

brylie commented Feb 21, 2017

There is a good discussion about URL characters on StackOverflow, that has a few solutions and mentions some security considerations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants