Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create data table pagination on /dashboard #259

Closed
4 tasks done
frenchbread opened this issue Jul 22, 2015 · 10 comments
Closed
4 tasks done

Create data table pagination on /dashboard #259

frenchbread opened this issue Jul 22, 2015 · 10 comments
Assignees
Milestone

Comments

@frenchbread
Copy link
Contributor

#183 - Related issue.

/dashboard page contains data table that displays usage logs. The data in the table is dynamic so when user does some filtering, or selects specific area on a chart, data in the table instantly updates.

Since data table is built using dc.js library, there is no pagination attached to the table "out of the box".

Definition of done

  • Determine if DC uses DataTables.js
  • Review, if it possible to attach pagination to dc data table
    • If not, review other solutions how data table can have pagination.
  • Demonstrate working data table with pagination
@bajiat
Copy link
Contributor

bajiat commented Jul 23, 2015

@frenchbread Can you please describe this task?

@JuusoV
Copy link
Contributor

JuusoV commented Jul 24, 2015

This can be done with Tabular Tables easily. Only issue is that we lose the dynamic functionality of DC.js. The table will show all the available data at the same time.

@frenchbread
Copy link
Contributor Author

@JuusoV Here is the working branch where we did some refactoring. Now it can be a bit easier to attach pagination to data table.

@brylie
Copy link
Contributor

brylie commented Jul 28, 2015

@JuusoV
Copy link
Contributor

JuusoV commented Jul 28, 2015

Awesome. Great stuff guys!

@brylie
Copy link
Contributor

brylie commented Jul 28, 2015

@frenchbread please get some sample data to work with. This way we won't have to wait for a round-trip from the Elastic server. The sample data can be passed in to the parseData() function now that the code is refactored.

@frenchbread
Copy link
Contributor Author

@brylie Here is the sample data example at gist

@JuusoV
Copy link
Contributor

JuusoV commented Jul 29, 2015

@frenchbread doing what he knows the best here. Really amazing job! The task is pretty much done and I will create PR asap after some cleanup.

@frenchbread
Copy link
Contributor Author

@JuusoV Ok, no problem. Create a PR whenever it's ready. Probably will need to do some more code refactoring but it is fine for now.

@bajiat
Copy link
Contributor

bajiat commented Jul 29, 2015

Thumbs up for you, guys! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants