Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow yml and txt in API configuration import #415

Closed
3 tasks done
bajiat opened this issue Aug 28, 2015 · 4 comments
Closed
3 tasks done

Allow yml and txt in API configuration import #415

bajiat opened this issue Aug 28, 2015 · 4 comments
Assignees
Milestone

Comments

@bajiat
Copy link
Contributor

bajiat commented Aug 28, 2015

Currently, API configuration file upload only accepts yaml and json file extensions. Add yml and txt to allow these file stypes. Check also if there is a MIME type filter that would be simpler to adopt.

Definition of done

  • Check the current upload code.
  • Check for MIME type filter, e.g. text/plain.
  • Make required changes to allow relevant formats.
@bajiat bajiat added this to the Sprint 11 milestone Aug 31, 2015
@55 55 added in progress and removed ready labels Sep 8, 2015
@55
Copy link
Contributor

55 commented Sep 8, 2015

Yml check is already in place.

@55
Copy link
Contributor

55 commented Sep 10, 2015

@frenchbread is it possible to add a txt files check? Does it make sense? Will it work with ace editor parsing?

@frenchbread
Copy link
Contributor

@elnzv Yes, it is possible. I don't think that is will make any sense because import file must contain yaml or json object with correct syntax. But initial task was to allow importing txt file, so I will add this functionality.

Will it work with ace editor parsing?

Yes. It will just require to modify code a little.

You can assign this issue to me since I am more familiar with it.

@bajiat
Copy link
Contributor Author

bajiat commented Sep 14, 2015

@frenchbread @elnzv We created a new task for txt parsing. See #467. Let's focus on that later. When everything else is completed and the PR is merged, go ahead and close the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants