Registration process 'hangs' when user is already signed in to Github

[brylie]

When a user clicks 'register with Github' and is already signed in to github, the server returns a 500 error.

[brylie]

Reported by @ccsr

[philippeluickx]

+1 this is still an issue. Should we at least hide that button for now as it is broken?

[brylie]

Ping @bajiat. Should we prioritize this bug?

[philippeluickx]

My suggestion is to remove the feature (button) and reprioritize to later.

[bajiat]

@jykae took a quick look and suspects that we are still using boilerplate
code for Github signin/signup. Would this be fixed by using accounts-github
instead? Info can be found from the Meteor guide. If yes, then I would
prioritize this.

[brylie]

We also need to find out if Apika needs Github authentication. Ping @kyyberi

[bajiat]

Self-assigned. Purpose is to check the workload for remaining sprint on Monday and then make a decision on whether we would be able to fix or hide.

[bajiat]

Here is info on login packages from Meteor guide, if that helps: https://guide.meteor.com/accounts.html#supported-login-services

[jykae]

@bajiat @brylie
Our implementation of Github does not completely follow guidelines: http://docs.meteor.com/api/accounts.html#service-configuration

Our login hook seems to try login manually with Github API:
https://github.com/apinf/platform/blob/develop/users/server/accounts_hooks.js#L38

Suggested way in guidelines to do login is to use loginWithGithub function, that uses saved service configuration. Service configuration is saved & updated right way.

I can successfully register & login with Github locally with development version.
Issue verified at least in nightly.

Gave estimation of 2 days to try out Github login in Meteor guidelines proposed way.

[jykae]

@bajiat @brylie ROOT_URL env variable had typo in nightly.apinf.io, missing "h". thanks @shaliko for quick fix.
Verified to work with @Laura-Sampo after change.

[bajiat]

@philippeluickx Can you also verify that you are able to register using Githubm authentication?

[philippeluickx]

All good now!

[brylie]

Cool. @bajiat @jykae can we close this issue?

[jykae]

@brylie @bajiat I am fine to close.