Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit in response time in analytics view #654

Closed
1 task
kyyberi opened this issue Nov 25, 2015 · 11 comments
Closed
1 task

Unit in response time in analytics view #654

kyyberi opened this issue Nov 25, 2015 · 11 comments
Assignees
Milestone

Comments

@kyyberi
Copy link

kyyberi commented Nov 25, 2015

As a API owner I want to see response time unit in analytics page where it list the API uage details. Now it says just "response time" and I assume that it is milliseconds.
response-time

Definition of done

  • Column header displays "Response time in ms"
@preriasusi
Copy link
Contributor

Should not be huge work to fix this. Proposing to next sprint.

@kyyberi
Copy link
Author

kyyberi commented Dec 4, 2015

Even I should be able to fix that :) it takes more effort to follow contribution process than making fix :)

@bajiat
Copy link
Contributor

bajiat commented Dec 14, 2015

@brylie Please check whether we can move the PR from master to develop.

@kyyberi
Copy link
Author

kyyberi commented Dec 14, 2015

I can do it again if needed

@55
Copy link
Contributor

55 commented Dec 14, 2015

@kyyberi, thanks.
We follow gitflow guidelines.
In order PR to be merged, name it as hotfix/fix-name-here and create it to be merged into develop.

@brylie
Copy link
Contributor

brylie commented Dec 14, 2015

The primary ideas is that the PR should be made against develop instead of master :-)

We also recognize the difficulty with contributing, and do not want the process to obstruct your contribution. Please let us know if you have any difficulties.

@kyyberi
Copy link
Author

kyyberi commented Dec 14, 2015

Referencing to generic processes page (some of which do not concern) is a good start. Next needed step is to make an example with the context in place. That lowers the barrier.

@brylie brylie removed the planning label Dec 15, 2015
@brylie
Copy link
Contributor

brylie commented Dec 15, 2015

Alright. This has been resolved. I accidentally committed directly to our develop branch, so yep... :-)

@kyyberi
Copy link
Author

kyyberi commented Dec 15, 2015

:) Nice.

@brylie
Copy link
Contributor

brylie commented Dec 16, 2015

Thanks for your feedback on our process. We will add brief instructions to our CONTRIBUTING.md, so that other contributors can quickly branch-commit-push-pr.

@brylie
Copy link
Contributor

brylie commented Dec 16, 2015

Closing this issue, since the unit time has been added to the table header.

@brylie brylie closed this as completed Dec 16, 2015
@brylie brylie added this to the Sprint 18 milestone Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants