Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actual frontend prefix when displaying usage instructions on API Backend page #707

Closed
brylie opened this issue Dec 10, 2015 · 5 comments
Assignees
Labels

Comments

@brylie
Copy link
Contributor

brylie commented Dec 10, 2015

The usage instructions on the API Backend page currently display as such:

https://umbrella.apinf.io[frontend-prefix]

This may be confusing, and omits the slash between the base url and path.

Consider how to fix this issue, possibly displaying the fully formatted URL with actual values foor base url and path.

Reference

The 'host' setting (in both/collections/settings.js ) does not enforce a trailing slash, either currently or in the upcoming settings feature:

"apinf.host": {
    type: String,
    regEx: SimpleSchema.RegEx.Url,
...
@brylie brylie added the APIKA label Dec 10, 2015
@brylie
Copy link
Contributor Author

brylie commented Dec 10, 2015

@frenchbread, will you please check this issue? Your work in Sprint 18 (#679) is related to this task.

@frenchbread
Copy link
Contributor

@brylie Ok, will look into that. Btw on my side the URL is displayed with a slash on place - https://umbrella.apinf.io/[Frontend prefix].

Would the [frontend-prefix] change to a real apiBackend.url_matches.frontend-prefix solve the problem?

@brylie
Copy link
Contributor Author

brylie commented Dec 18, 2015

Yep. Did you complete this task? I cannot recall.

@frenchbread
Copy link
Contributor

@brylie If i'm correct it has been fixed & merged to develop branch.

@frenchbread
Copy link
Contributor

Created a PR #726. Please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants