Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n file contains concatenated strings #737

Closed
4 tasks done
bajiat opened this issue Dec 31, 2015 · 1 comment
Closed
4 tasks done

i18n file contains concatenated strings #737

bajiat opened this issue Dec 31, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@bajiat
Copy link
Contributor

bajiat commented Dec 31, 2015

The i18n file contains strings that are parts of sentence.

The first rule of software internationalisation is never to use concatenated strings (Ui texts that are built from several parts). They can create localisation problems, because either the person translating does not know, which strings go together or translator cannot use natural word order for the entire sentence in target language, because a sentence has been split.

One example from the Apinf strings:

  • "Meanwhile, you may" (key: Not Found.notFound_Message_Part2)
  • "return to a previous page" (key: Not Found.notFound_Message_Part3)

All concatenated strings should be combined into entire meaningful text strings. Use parameters for replaceable items, if necessary.

Definition of done

  • Find all cases of concatenated strings.
  • Modify corresponding template to use only one i18n string in place of multiple parts of string.
  • Modify the i18n file to merge multiple parts into one string corresponding template.
  • If the strings have been concatenated because of HTML tags, make sure they get included and are not displayed on UI.
@55
Copy link
Contributor

55 commented Feb 4, 2016

There is a blocking issue with links.
Can't get those to .json files. They don't work from there. Things like <br> or <strong> are working, but not <a href="#">link</a>.

Created related issue on i18n repo - TAPevents/tap-i18n#142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants