Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subscription for latestApiBackends template #742

Closed
brylie opened this issue Dec 31, 2015 · 3 comments
Closed

Fix subscription for latestApiBackends template #742

brylie opened this issue Dec 31, 2015 · 3 comments
Assignees

Comments

@brylie
Copy link
Contributor

brylie commented Dec 31, 2015

PR #727 was merged with a global subscription. Update the latestApiBackends template to use a template level subscription.

Subscriptions should happen in the Template.created callback, rather than within template helpers. They should be attached to the template instance, rather than globally.

Template.latestApiBackends.created = function () {
  // Get named reference to Template instance
  let instance = this;

  // Subscribe to latest API Backends, template level
  instance.subscribe("latestApiBackends");
};

Please issue a hotfix pull-request for this subscription issue.

References

@brylie brylie added this to the Sprint 20 milestone Dec 31, 2015
@brylie
Copy link
Contributor Author

brylie commented Dec 31, 2015

@frenchbread or @jykae would you please consider contributing this small hotfix?

@frenchbread
Copy link
Contributor

I'll take this one.

@frenchbread
Copy link
Contributor

Created PR #748. Please review.

@brylie brylie closed this as completed in cb5e0db Jan 6, 2016
@brylie brylie removed the in progress label Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants