Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine how to set the site title tag dynamically from the settings collection #787

Closed
brylie opened this issue Jan 22, 2016 · 1 comment
Assignees
Milestone

Comments

@brylie
Copy link
Contributor

brylie commented Jan 22, 2016

For SEO, the site title is currently configured from a variable set in /lib/_config/_config.js. Determine how to set the site SEO settings from the Settings collection, rather than hard-coding them into a file.

@brylie
Copy link
Contributor Author

brylie commented Jan 29, 2016

It turns out that we can set the site title when the template is rendered. That way we have access to the settings collection, etc. We can also set the page title from within layouts, but individual templates may be easier to maintain, since the layout title code may clash with individual templates.

@brylie brylie added in progress and removed ready labels Jan 29, 2016
@bajiat bajiat added this to the Sprint 21 milestone Jan 29, 2016
@brylie brylie closed this as completed Feb 1, 2016
@brylie brylie removed the in progress label Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants