Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a recipe for unit testing #889

Closed
bajiat opened this issue Feb 22, 2016 · 11 comments
Closed

Create a recipe for unit testing #889

bajiat opened this issue Feb 22, 2016 · 11 comments
Assignees
Labels

Comments

@bajiat
Copy link
Contributor

bajiat commented Feb 22, 2016

Create a model or recipe for a unit test case.

@bajiat
Copy link
Contributor Author

bajiat commented Feb 22, 2016

@ashakunt Can you assign this to Alapan? To be completed by 4 March

@as33ms
Copy link
Contributor

as33ms commented Feb 23, 2016

@Alapan is working on it already.

@as33ms as33ms assigned Alapan and unassigned as33ms Feb 23, 2016
@Alapan Alapan mentioned this issue Feb 24, 2016
@as33ms
Copy link
Contributor

as33ms commented Feb 25, 2016

First recipe for unit testing was pushed to "tests" branch. @Alapan can provide more details about how to run and its dependencies.

@Alapan
Copy link
Contributor

Alapan commented Feb 25, 2016

I wrote the tests with Jasmine and Velocity. The commands I used to install them were:

meteor add sanjo:jasmine
meteor add velocity:html-reporter

When starting the localhost application by 'meteor --settings PATH-TO-apinf.config.json', the Velocity UI should show the test results.

@Alapan
Copy link
Contributor

Alapan commented Feb 29, 2016

For testing the template events I added a new package:

meteor add xolvio:template-isolator

@bajiat
Copy link
Contributor Author

bajiat commented Mar 2, 2016

@Alapan Will you open a PR on this task?

@Alapan Alapan mentioned this issue Mar 2, 2016
@Alapan
Copy link
Contributor

Alapan commented Mar 2, 2016

@bajiat A pull request was created.

@Alapan Alapan mentioned this issue Mar 4, 2016
@Alapan
Copy link
Contributor

Alapan commented Mar 4, 2016

I created a new pull request with branch 'test-recipes' and deleted the 'tests' branch. This was because the earlier branch had conflicts since it was mistakenly created on top of the 'master' branch, and not 'develop'. The commits from 'tests' were cherry-picked to 'test-recipes', and the earlier pull request referencing this issue was closed.

@as33ms
Copy link
Contributor

as33ms commented Mar 21, 2016

@bajiat @brylie should this be closed now?

cc: @Alapan

@brylie
Copy link
Contributor

brylie commented Mar 21, 2016

Jep.

@brylie
Copy link
Contributor

brylie commented Mar 21, 2016

In the future, include the following text in PR descriptions:

  • Closes #[issue number]

Github will then automatically close the issue when the PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants