Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API status check giving false error message #918

Closed
jykae opened this issue Mar 18, 2016 · 1 comment
Closed

API status check giving false error message #918

jykae opened this issue Mar 18, 2016 · 1 comment
Assignees
Milestone

Comments

@jykae
Copy link
Contributor

jykae commented Mar 18, 2016

Behaviour

After adding API that requires authorization, API status shows:
"API backend is down for some reason. Please contact support."

Example:
"Yle API uses app_id and app_key URL parameters for authentication, Apinf should be flexible for different kind of API authorizations. It's not good to show "API backend is down for some reason. Please contact support.", if we are getting 401 not authorized."

Above comment from issue: https://github.com/apinf/api-umbrella-dashboard/issues/917

Expected

When getting 401, show info "API requires authentication" or allow 401 to be successful status.

@brylie
Copy link
Contributor

brylie commented Jun 6, 2016

@frenchbread will you take this task? It may be that we need to pass the HTTP response code to the user, and allow other status codes than 200.

@frenchbread frenchbread self-assigned this Jun 6, 2016
@brylie brylie changed the title API authentication parameters in URL parameters API status check giving false error message Jun 6, 2016
@bajiat bajiat added this to the Sprint 24 milestone Jun 7, 2016
@jykae jykae removed the in progress label Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants