Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google: Security Definitions missing (apiKey) #35

Closed
rbren opened this issue Feb 22, 2016 · 5 comments
Closed

Google: Security Definitions missing (apiKey) #35

rbren opened this issue Feb 22, 2016 · 5 comments

Comments

@rbren
Copy link
Contributor

rbren commented Feb 22, 2016

No description provided.

@IvanGoncharov
Copy link
Member

Do you mean it require api key?

@rbren
Copy link
Contributor Author

rbren commented Feb 25, 2016

I'm not sure how it's supposed to handle auth, but it's a paid API so I
know it uses some kind of auth

Bobby Brennan
bobby.brennan@gmail.com

On Thu, Feb 25, 2016 at 4:33 PM, Ivan Goncharov notifications@github.com
wrote:

Do you mean it require api key?


Reply to this email directly or view it on GitHub
#35 (comment)
.

@IvanGoncharov
Copy link
Member

@rbren
Copy link
Contributor Author

rbren commented Feb 25, 2016

I'd argue that key and oauth_token should be in security definitions. For
example you have to re-enter your API key in the lucybot console each time
you change operations, but if it's a secdef the console will remember it

Having it as a parameter is sufficient though, especially if it's not an
easy fix
On Feb 25, 2016 5:37 PM, "Ivan Goncharov" notifications@github.com wrote:

@bobby-brennan https://github.com/bobby-brennan All Google APIs have
this parameter:

https://github.com/APIs-guru/api-models/blob/master/APIs/googleapis.com/translate/v2/swagger.yaml#L40


Reply to this email directly or view it on GitHub
#35 (comment)
.

@IvanGoncharov
Copy link
Member

Problem that I can distinguish between APIs that work with keys and one working without.
So I will add security definition but will make it optional
It's not ideal but definitely step in the right direction.
Sounds good?

@MikeRalphson MikeRalphson changed the title Google Translate: Security Definitions missing Google: Security Definitions missing (apiKey) Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants