Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide scaled version of API logo. #41

Closed
IvanGoncharov opened this issue Mar 10, 2016 · 1 comment
Closed

Provide scaled version of API logo. #41

IvanGoncharov opened this issue Mar 10, 2016 · 1 comment

Comments

@IvanGoncharov
Copy link
Member

Continue discussions from #36:

@darosh:

Regarding logos and hub:

  • they have various size, ratio and quality and in my opinion they would need some preprocessing not to be scaled in browser and perhaps merging into single CSS sprite image might be a good idea too
  • Google Books logo is outdated for example
  • hub.html
    • has no final design but I will probably prefer to keep it simple without logos, using the 🌈 generator based on logo colors,
    • right now I just need the links to the Swagger UI I work on, maybe later I will change the cards into something expandable showing more metadata you provide in the list.json including logos...
@IvanGoncharov
Copy link
Member Author

@darosh

it is always good to know you have some validation in place

It's bigger showstopper I have for adding new APIs. I need to manually fix them before adding into the collection. You can see fixup patches here.

they have various size, ratio and quality and in my opinion they would need some preprocessing

If you use my API you actually using caching logos from here. So I already have mechanism for doing preprocessing, so I can scale non-svg images and provide them in couple of sizes.

single CSS sprite image

One image for all collection will be huge.
So right now you page is rendered from up to bottom and user don't care that some logo at botom of page still downloading. In case of packed logos user need to wait for all of them to download.

All my images are served from cache on github so browser reuse same connections and it's pretty efective already.

has no final design but I will probably prefer to keep it simple without logos

If you have some idea how I can make situations with logo better, feel free to suggest it here.
Obviously I can't manually process each logo, but I can make some preprocessing steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant