Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 用户注册功能bug #1052

Closed
DOnlyone opened this issue Jul 9, 2023 · 2 comments
Closed

fix: 用户注册功能bug #1052

DOnlyone opened this issue Jul 9, 2023 · 2 comments
Assignees
@laboonly @nagisakon
Labels
bug Something isn't working

Comments

@DOnlyone
Copy link

DOnlyone commented Jul 9, 2023 •
edited
Loading

2023-07-09.10.07.25.mov

描述Bug
当用户注册账号时两次密码不一致可以注册成功

重现步骤
重现行为的步骤：

  1. 前往用户注册界面
  2. 输入邮箱，注册时两次填写密码不一致即可
  3. 点击注册，即可登录

期望行为
注册时两次密码应该为一致才允许用户注册。

屏幕截图
已经上传录屏。

电脑版（请填写以下信息）：

其他上下文
无
@DOnlyone DOnlyone added the bug Something isn't working label Jul 9, 2023
llkevin13579 added a commit to llkevin13579/apitable that referenced this issue Jul 12, 2023
@llkevin13579
fix: sign up password match issue (apitable#1052)
aa612b1
@llkevin13579 llkevin13579 mentioned this issue Jul 12, 2023
Merged
@llkevin13579
Copy link
Contributor

I fixed this issue and please help review it.
#1074
@mr-kelly @ChambersChan @DOnlyone @nagisakon @laboonly

wangkailang pushed a commit that referenced this issue Jul 14, 2023
@llkevin13579 @mr-kelly
fix: sign up password match issue (#1052) (#1074)
4461601 
Submit a pull request for this project.

Fix this issue: #1052

# Why? 
There is an issue when matching passwords. The previous logic only
compares the password length.
When the user enters 2 passwords with the same length but they are
different, it could still register.


# What?
I fixed the issue by adding the following logic
```
if(data.password !== data.confirmPassword) {
        errorMsg.confirmPassword = t(Strings.password_not_identical_err);
        return false;
}
```


# How?
It will be more strict after fixing the issue in the sign-up stage.

Co-authored-by: Kelly Chan <kelly@apitable.com>
@llkevin13579
Copy link
Contributor

@DOnlyone This issue has been solved (#1074)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laboonly laboonly

@nagisakon nagisakon

Labels
bug Something isn't working
Projects
APITable
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@laboonly @llkevin13579 @DOnlyone @ChambersChan @nagisakon