Disallow null returns where should not be possible

phpstan.neon

@@ -5,14 +5,22 @@ includes:
 
 parameters:
 	ignoreErrors:
+		# Missing strict comparison
 		- '#^Construct empty\(\) is not allowed. Use more strict comparison.$#'
 		- '#^Only booleans are allowed in#'
 		- '#string|null given.$#'
+
+		# Magic access
 		- '#^Access to private property \$previous of parent class Exception.$#'
+
+		# Shoudl not happen - $method and $class are just missing in __construct
 		- '#^Cannot call method getMethod\(\) on Apitte\\Core\\Schema\\EndpointHandler\|null.$#'
 		- '#^Cannot call method getClass\(\) on Apitte\\Core\\Schema\\EndpointHandler\|null.$#'
 
 		# There is no apitte/negotiation dependency
 		- '#^Return typehint of method Apitte\\Core\\Http\\ApiResponse::getEntity\(\) has invalid type Apitte\\Negotiation\\Http\\AbstractEntity.$#'
 		- '#^Parameter \$entity of method Apitte\\Core\\Http\\ApiResponse::withEntity\(\) has invalid typehint type Apitte\\Negotiation\\Http\\AbstractEntity.$#'
 		- '#^Call to static method from\(\) on an unknown class Apitte\\Negotiation\\Http\\#'
+
+		# Maybe will cause application fail - DecoratorManager::decorateResponse could return null, but DecoratedDispatcher is not always able to handle it.
+		- '#Method Apitte\\Core\\Dispatcher\\DecoratedDispatcher::handle\(\) should return Psr\\Http\\Message\\ResponseInterface but returns Psr\\Http\\Message\\ResponseInterface|null.#'

src/Dispatcher/CoreDispatcher.php

@@ -24,7 +24,7 @@ public function __construct(IRouter $router, IHandler $handler)
 		$this->handler = $handler;
 	}
 
-	public function dispatch(ServerRequestInterface $request, ResponseInterface $response): ?ResponseInterface
+	public function dispatch(ServerRequestInterface $request, ResponseInterface $response): ResponseInterface
 	{
 		// Try match request to our routes
 		$matchedRequest = $this->match($request, $response);
@@ -43,7 +43,7 @@ protected function match(ServerRequestInterface $request, ResponseInterface $res
 		return $this->router->match($request);
 	}
 
-	protected function handle(ServerRequestInterface $request, ResponseInterface $response): ?ResponseInterface
+	protected function handle(ServerRequestInterface $request, ResponseInterface $response): ResponseInterface
 	{
 		$response = $this->handler->handle($request, $response);
 

src/Dispatcher/DecoratedDispatcher.php

@@ -36,7 +36,7 @@ public function __construct(IRouter $router, IHandler $handler, DecoratorManager
 	 * @param ApiRequest|ServerRequestInterface $request
 	 * @param ApiResponse|ResponseInterface $response
 	 */
-	public function dispatch(ServerRequestInterface $request, ResponseInterface $response): ?ResponseInterface
+	public function dispatch(ServerRequestInterface $request, ResponseInterface $response): ResponseInterface
 	{
 		try {
 			// Route and call handler
@@ -64,7 +64,7 @@ public function dispatch(ServerRequestInterface $request, ResponseInterface $res
 	 * @param ApiRequest $request
 	 * @param ApiResponse $response
 	 */
-	protected function handle(ServerRequestInterface $request, ResponseInterface $response): ?ResponseInterface
+	protected function handle(ServerRequestInterface $request, ResponseInterface $response): ResponseInterface
 	{
 		// Pass endpoint to response
 		if (($endpoint = $request->getAttribute(RequestAttributes::ATTR_ENDPOINT, null))) {

src/Dispatcher/IDispatcher.php

@@ -8,6 +8,6 @@
 interface IDispatcher
 {
 
-	public function dispatch(ServerRequestInterface $request, ResponseInterface $response): ?ResponseInterface;
+	public function dispatch(ServerRequestInterface $request, ResponseInterface $response): ResponseInterface;
 
 }