Feature: added @RequestMapper/@ResponseMapper #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
f3l1x
commented
Jan 16, 2018
f3l1x
commented
- resolve Add @RequestMapping #4, Improve ArraySerializator #9, Better handling path/query parameters in query #10
…r into more methods
f3l1x
force-pushed
the
feature/schema-refactoring
branch
from
a0d438f
to
1dea45b
Compare
kralmichal
reviewed
Jan 16, 2018
| */ | ||
| public function fromRequest(ApiRequest $request) | ||
| { | ||
| if (in_array($request->getMethod(), [Endpoint::METHOD_POST, Endpoint::METHOD_PUT])) { |
There was a problem hiding this comment.
What about PATCH method?
This was referenced Jan 18, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.