PHP 7.1, updated dependencies, removed unused classes #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3l1x
reviewed
Jul 4, 2018
| // If there's no decorator to handle this exception, throw again | ||
| if ($response === NULL) throw $e; | ||
| if ($this->decoratorManager->hasDecorators(IDecorator::ON_DISPATCHER_EXCEPTION)) { | ||
| // Trigger exception decorator |
There was a problem hiding this comment.
Takhle to nepujde, ono se muze stat, ze tam decorator je, ale ze vrati null, protoze s danou exception nic nedela. Ten puvodni kod byl dobre.
f3l1x
reviewed
Jul 4, 2018
src/Http/RequestAttributes.php
Outdated
| const ATTR_REQUEST_ENTITY = 'apitte.core.request.entity'; | ||
| const ATTR_RESPONSE_ENTITY = 'apitte.core.response.entity'; | ||
| public const | ||
| ATTR_SCHEMA = 'apitte.core.schema', |
There was a problem hiding this comment.
Ani mi to nepiš, je to skoro všude...
f3l1x
force-pushed
the
php7.1
branch
2 times, most recently
from
775229a
to
9f5a234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18