Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We're disabling the shadowed-function warning #2

Open
apjanke opened this issue Apr 5, 2020 · 1 comment
Open

We're disabling the shadowed-function warning #2

apjanke opened this issue Apr 5, 2020 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@apjanke
Copy link
Owner

apjanke commented Apr 5, 2020

We define a package-scoped function error() inside the +logger package. Octave mistakenly thinks that this shadows the built-in error() function, and repeatedly issues warnings like this:

warning: function [...]/SLF4O/inst/+logger/error.m shadows a built-in function

So we're just doing warning off Octave:shadowed-function in PKG_ADD. That's a gross hack. See if that can be fixed.

@apjanke
Copy link
Owner Author

apjanke commented Apr 5, 2020

Possible workaround: convert the +logger package to a @logger class and make all the functions static methods on it.

@apjanke apjanke added the bug Something isn't working label Apr 5, 2020
@apjanke apjanke added this to the The Future milestone Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant