Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sortrows harmonization with Octave negative-index inputs #12

Open
apjanke opened this issue Mar 2, 2019 · 0 comments
Open

sortrows harmonization with Octave negative-index inputs #12

apjanke opened this issue Mar 2, 2019 · 0 comments
Assignees
Labels
bug Something isn't working tables The table stuff
Milestone

Comments

@apjanke
Copy link
Owner

apjanke commented Mar 2, 2019

table.sortrows is implemented in terms of sortrows, including passing its options on to the individual variables' sortrows calls. The problem is that table.sortrows declares that it supports all the Matlab sortrows arguments and options. But Octave's sortrows doesn't support that. In particular:

  • Octave's sortrows doesn't support MissingPlacement or ComparisonMethod name/val options.
  • Octave represents descending column sorts with a negative column index, instead of a separate 'ascend'/'descend' option.

Harmonize this as much as you can. This may include putting in an upstream Octave bug to request support for additional Matlab-compatible calling forms in its native sortrows. Also, decide whether table's sortrows, in particular its column and 'ascend'/'descend' options should primarily match Octave's or Matlab's, or if it's going to try to combine both in its public interface.

@apjanke apjanke mentioned this issue Mar 2, 2019
58 tasks
@apjanke apjanke self-assigned this Mar 2, 2019
@apjanke apjanke added the bug Something isn't working label Mar 2, 2019
@apjanke apjanke added this to the The Future milestone Mar 2, 2019
@apjanke apjanke added this to Needs triage in Octave-Tablicious via automation May 5, 2019
@apjanke apjanke moved this from Needs triage to Low priority in Octave-Tablicious May 5, 2019
@apjanke apjanke added the tables The table stuff label May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tables The table stuff
Projects
Status: Low priority
Octave-Tablicious
  
Low priority
Development

No branches or pull requests

1 participant