Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edge aliasing and edge constraints #119

Merged
merged 8 commits into from Jun 6, 2022
Merged

Add edge aliasing and edge constraints #119

merged 8 commits into from Jun 6, 2022

Conversation

j6k4m8
Copy link
Member

@j6k4m8 j6k4m8 commented Jun 6, 2022

This PR adds support for edge aliases (first described in #110) and comparisons between edge attributes with values and with other edges.

This enables syntax like this:

A -> B as ab
B -> A as ba

ab.weight > ba.weight
  • Add support in the DSL
  • Add support in the parser + transformer
  • Add support in the executors:
    • GrandIso
    • NetworkX
    • NeuPrint
    • Neo4j

I am going to push macro support in a separate PR, since this one is getting pretty lengthy already!

@j6k4m8 j6k4m8 self-assigned this Jun 6, 2022
@j6k4m8 j6k4m8 added this to the Version 1.0.0 milestone Jun 6, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #119 (db4154a) into master (16e5f84) will increase coverage by 1.04%.
The diff coverage is 98.06%.

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   90.12%   91.17%   +1.04%     
==========================================
  Files          22       22              
  Lines        1793     2028     +235     
==========================================
+ Hits         1616     1849     +233     
- Misses        177      179       +2     
Impacted Files Coverage Δ
dotmotif/parsers/v2/__init__.py 94.68% <93.67%> (-0.74%) ⬇️
dotmotif/__init__.py 97.59% <100.00%> (+3.33%) ⬆️
dotmotif/executors/GrandIsoExecutor.py 83.33% <100.00%> (+0.47%) ⬆️
dotmotif/executors/Neo4jExecutor.py 72.61% <100.00%> (+1.01%) ⬆️
dotmotif/executors/NetworkXExecutor.py 92.30% <100.00%> (+0.83%) ⬆️
dotmotif/executors/test_dm_cypher.py 100.00% <100.00%> (ø)
dotmotif/executors/test_grandisoexecutor.py 100.00% <100.00%> (ø)
dotmotif/executors/test_networkxexecutor.py 100.00% <100.00%> (ø)
dotmotif/parsers/v2/test_v2_parser.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16e5f84...db4154a. Read the comment docs.

@j6k4m8 j6k4m8 merged commit 07e3b7c into master Jun 6, 2022
@j6k4m8 j6k4m8 mentioned this pull request Jun 7, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants