Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the accessible labels of questionnaire forms #592

Closed
mtthwhggns opened this issue Jun 25, 2020 · 3 comments · Fixed by apluslms/mooc-grader#78
Closed

Review the accessible labels of questionnaire forms #592

mtthwhggns opened this issue Jun 25, 2020 · 3 comments · Fixed by apluslms/mooc-grader#78
Labels
area: accessibility Related to accessibility, e.g., accessibility standards and guidelines service: mooc-grader This issue concerns about a service MOOC-Grader

Comments

@mtthwhggns
Copy link
Contributor

mtthwhggns commented Jun 25, 2020

This is regarding the questionnaire type.

Some submission form controls are associated with a label which only contains a question number.

We should explore whether it makes sense to wrap the entire question inside the label element.

Related: https://apluslms.github.io/accessibility-audit/patterns/fixable-a/form-controls/

@mtthwhggns mtthwhggns added the area: accessibility Related to accessibility, e.g., accessibility standards and guidelines label Jun 25, 2020
@mtthwhggns
Copy link
Contributor Author

To clarify, the red is the accessible label. The blue is it's parent.

localhost_8000_def_current_m01_introduction_07_questionnaires_ (1)

@markkuriekkinen
Copy link
Member

Questionnaire HTML comes from the MOOC-Grader.

If the whole question is wrapped inside the label element, does it cause problems with very long questions or if the question contains mathematics (MathJax)?

Is there an alternative for wrapping the whole question in the label? (just curious)

@mtthwhggns
Copy link
Contributor Author

@Mankro the short answer is I'm not sure. This needs testing manually. I'll try and find some time tomorrow to try it.

@raphendyr raphendyr added the service: mooc-grader This issue concerns about a service MOOC-Grader label Jun 30, 2020
@raphendyr raphendyr changed the title Review the accessible labels of submission forms Review the accessible labels of questionnaire forms Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: accessibility Related to accessibility, e.g., accessibility standards and guidelines service: mooc-grader This issue concerns about a service MOOC-Grader
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants