Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset, amongst other things, adds better support for v5.14+
Style notation.
As-is, it erroneously places the AUTHORITY declaration after the
1
at the end, like so:Which is rather bad, and the augmented code now instead does:
In the process of doing so, I incidentally discovered the code that inserted the
our $AUTHORITY
stanzas caused Authority.pm to self-positive when scanning itself:And additionally, the code was a little hard to parse as to what was doing what, so I refactored the hell out of it, and it now uses templates ( sprintf ) to avoid detection instead of a silly \x20 hack.
I also in my travels noticed the code has several indentation styles, and could much do with a bundled .perltidyrc file that can be gauranteed upon, but have left my already-tided form of the same in a seperate branch.