User defined 'opts' are never used on function call

[sreuter]

I need to overwrite some of the default options when calling buildImage, as I want to set opts.path to '/build?t=nodeapp&q' to set a name/tag for the resulting image.

Unfortunately, the opts object given on call get completely ignored/overwritten by the defaults.

This seems to be a general problem, not only for docker.buildImage();

Docker.prototype.buildImage = function(file, opts, callback) {
  var self = this;
  var opts = {
    path: '/build?',
    method: 'POST',
    file: file,
    options: opts,
    isStream: true,
    statusCodes: {
      200: true,
      500: "server error"
    }
  };

  this.modem.dial(opts, function(err, data) {
    callback(err, data);
  });
};

[apocas]

You just need to do something like this then:

docker.buildImage('./test/test.tar', {t: 'nodeapp'}, handler);

Check this: https://github.com/apocas/docker-modem/blob/master/lib/modem.js#L36

[sreuter]

Uh, yay, spotted that one minute ago while digging trough the docker-modem code ;-)

Thanks anyway, this is an awesome module!