Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support restoring from a checkpoint when starting containers #396

Closed
pronvit opened this issue Aug 22, 2017 · 5 comments
Closed

Support restoring from a checkpoint when starting containers #396

pronvit opened this issue Aug 22, 2017 · 5 comments

Comments

@pronvit
Copy link

pronvit commented Aug 22, 2017

Currently if you pass checkpoint parameters to container.start() call, they will be sent as POST data and you'll get "starting container with non-empty request body was deprecated since v1.10 and removed in v1.12" error.

These parameters must be passed in url, i.e.

path: '/containers/' + this.id + '/start?checkpoint='+encodeURIComponent(checkpoint)+'&checkpoint-dir='+encodeURIComponent(checkpointDir)+'&'
@pronvit pronvit changed the title Support restoring from checkpoint when starting containers Support restoring from a checkpoint when starting containers Aug 22, 2017
@apocas
Copy link
Owner

apocas commented Sep 8, 2017

You can call container.start() using "_query" option.
Something like: container.start({'_query': {'checkpoint': ...}})

@pronvit
Copy link
Author

pronvit commented Sep 8, 2017

Thanks, didn't know about the _query option.

@apocas
Copy link
Owner

apocas commented Sep 8, 2017

Soon I will probably default container.start options to query/url instead of body, if you don't send _query.
This way it won't be a breaking change, eliminating the necessity to use it in this endpoint.

@mvila
Copy link

mvila commented Oct 10, 2017

I tried this "_query" options, it doesn't work for me, there is still the deprecation error.

@apocas: I really need to pass options to container.start(), any progress on this issue?

@apocas
Copy link
Owner

apocas commented Apr 5, 2021

Closing this one (shouldn't be an issue nowadays), reopen if needed.

@apocas apocas closed this as completed Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants