Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run doesn't allow specification of Env #51

Closed
dweinstein opened this issue Mar 18, 2014 · 4 comments
Closed

run doesn't allow specification of Env #51

dweinstein opened this issue Mar 18, 2014 · 4 comments

Comments

@dweinstein
Copy link

In run optsc is declared inside the function and Env is declared null There are use cases where one would want to be able to pass a non-null Env

@apocas
Copy link
Owner

apocas commented Mar 19, 2014

Dockerode's run was made basically as an entry point to dockerode, for more complex use case you really should implement your own. (create->attach->start->wait)

But since I seeing a lot of interest on this, probably the best course of action is to accept an optional options object and merge it with the internal optsc.

Ex:
Docker.prototype.run = function(image, cmd, streamo, [options], callback)
Merging options with optsc, giving preference to options.
Don't want this to be a breaking change, so options and callback type should be validated.

If you are not up to do a PR, I can implement this later today/tomorrow :)

@apocas
Copy link
Owner

apocas commented Apr 2, 2014

In master now. b5758de

Yet to be published.

@dweinstein
Copy link
Author

👍

@apocas
Copy link
Owner

apocas commented Apr 10, 2014

Published v1.2.10

@apocas apocas closed this as completed Apr 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants