You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Dockerode's run was made basically as an entry point to dockerode, for more complex use case you really should implement your own. (create->attach->start->wait)
But since I seeing a lot of interest on this, probably the best course of action is to accept an optional options object and merge it with the internal optsc.
Ex:
Docker.prototype.run = function(image, cmd, streamo, [options], callback)
Merging options with optsc, giving preference to options.
Don't want this to be a breaking change, so options and callback type should be validated.
If you are not up to do a PR, I can implement this later today/tomorrow :)
In run
optsc
is declared inside the function and Env is declarednull
There are use cases where one would want to be able to pass a non-nullEnv
The text was updated successfully, but these errors were encountered: