Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Github Actions Workflow #8

Closed
apoclyps opened this issue Oct 3, 2020 · 3 comments · Fixed by #11
Closed

Improve Github Actions Workflow #8

apoclyps opened this issue Oct 3, 2020 · 3 comments · Fixed by #11

Comments

@apoclyps
Copy link
Owner

apoclyps commented Oct 3, 2020

What's Required?

The current test_and_build workflow run's on every pull request.

This should be split into a test workflow and a build workflow so releases are only produced on a merge to master.

See: https://github.com/apoclyps/magic-home/blob/master/.github/workflows/test_and_build.yml

Acceptance Criteria

  • build and test should be 2 separate workflows
  • build should only run on a merge to master
  • test should run on every pull request
@rafaelrubbioli
Copy link
Contributor

Hi! I`m still learning to use the workflows, but i attempted solving this. Thanks!

@apoclyps
Copy link
Owner Author

apoclyps commented Oct 3, 2020

Hi @rafaelrubbioli 👋

Thank you for the pull request; I had a quick look at the content's of the pull request and it looks good so far 👍

@apoclyps
Copy link
Owner Author

apoclyps commented Oct 3, 2020

You may also be interested in #9 - It incorporates a few more action's from the market place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants