[Feature] Enhance visibility of security tag pull request titles

[apoclyps]

Is your feature request related to a problem? Please describe.
I would like to highlight [Security] updates in yellow to identify them uniquely within a list of pull requests

Describe the solution you'd like
I would like the pull request title to highlight [Security] in yellow, whilst the rest of the text remains white.

Additional context

You can find a project with security updates required at apoclyps/home_automation

export REPOSITORY_CONFIGURATION="apoclyps/dexi,apoclyps/my-dev-space,apoclyps/home_automation"
reviews dashboard

This will produce results similar to the following

Implementation Notes

The colour is currently set to "[white]" by adding this string as a prefix to the pull request title in

reviews/reviews/layout/helpers.py

Lines 27 to 46 in fbd8b23

	for pr in pull_requests:
	approved = "[green]Approved" if pr.approved else ""
	updated_at = humanize.naturaltime(pr.updated_at)
	colour = ""
	if (datetime.now() - pr.updated_at).days >= 7:
	colour = "[red]"
	elif (datetime.now() - pr.updated_at).days >= 1:
	colour = "[yellow]"
	updated_at = f"{colour}{updated_at}"
	labels = ", ".join([label.name for label in pr.labels])
	table.add_row(
	f"[white]{pr.number} ",
	f"[white]{pr.title}",
	f"{labels}",
	f"{updated_at}",
	f"{approved}",
	)

The Rich library has support for applying additional formatting to a line of text.

See: https://github.com/willmcgugan/rich/blob/e34eadb3a9354c2469fa2112400ce2690f2663ba/rich/__main__.py#L103-L106 which shows the markup section from https://raw.githubusercontent.com/willmcgugan/rich/master/imgs/features.png

[carrickkv2]

I'll look into this.

[yushao2]

take

[yushao2]

After thinking on this for a bit more, would it make sense to instead implement a feature whereby a user can configure custom colours for specific labels?

This becomes a non-trivial problem but would definitely allow for more flexibility -- especially if [Security] is not a common label used by devs through all projects/repos -- just my two cents.

And of course I might be wrong here as I am not too exposed to many projects

[apoclyps]

@yushao2 I like your idea and my preference is to allow for configurable colours based on user-defined labels. As labels are very custom and it's hard to limit this to a specific subset.

You can find a feature request to colourise the labels in #85 which aligns with the changes to the Labels section; we should include your suggested change in the scope of that feature request and we can discuss it further if you have any thoughts or concerns around how we might implement it.

As for this feature request, it's limited to the Security tag that is prefixed to pull requests title in a pull request. This is a known standard set for security pull requests by placing Security in the title when raised by Github/Dependabot so there shouldn't be any variants to support.

[yushao2]

@yushao2 I like your idea and my preference is to allow for configurable colours based on user-defined labels. As labels are very custom and it's hard to limit this to a specific subset.

You can find a feature request to colourise the labels in #85 which aligns with the changes to the Labels section; we should include your suggested change in the scope of that feature request and we can discuss it further if you have any thoughts or concerns around how we might implement it.

As for this feature request, it's limited to the Security tag that is prefixed to pull requests title in a pull request. This is a known standard set for security pull requests by placing Security in the title when raised by Github/Dependabot so there shouldn't be any variants to support.

Ah, okay. My bad on this -- I thought it was to be for Security labels. I'll take this up and give it a shot.

Thanks