Swift 4 support? #13
Comments
|
From what I see, no one has updated the thrift fork, so the generated code is not currently usable in swift 4 |
I have forked repo for tests. Look into feature branch.
|
|
But that means I'll need to switch all my code to swift 3.2, right? I can't use swift 4 in other targets? |
|
Also, swift 3.2 doesn't work either. I switched my target to be swift 3.2, the errors reduce, but there are still 144+
|
|
Not related to Swift4 |
AndrewSB
added a commit
to AndrewSB/Thrift-Swift
that referenced
this issue
Oct 24, 2017
Happy to take in edits! I'm assuming a number of the people who look at the thrift docs for swift are going to be exclusively iOS engineers and completely unfamiliar with the unixisms to install closes apocolipse#11 closes apocolipse#13
|
apocolipse's repositories currently support swift 4, I apologize for my confusion |
|
Ok to close? Or are there any remaining open questions in this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm trying to use this library in Swift 4. From what I see, there exist forks that have upgraded to swift 4 (https://github.com/apocolipse/Thrift-Swift/network). See https://github.com/Petro-Lomaka/Thrift-Swift, for example.
The framework they vend seems to work for me.
The command line
thrift, on the other hand, seems not to. I'm trying to use @Petro-Lomaka's fork (same guy), but the generated code doesn't conform to the Thrift swift module. I'm currently trying to uninstall my thrift, then reinstall from brew, and then follow the instructions in #11 with thethriftfork.Can we start the process of moving this library to swift 4?
The text was updated successfully, but these errors were encountered: