Skip to content
This repository has been archived by the owner on Sep 7, 2021. It is now read-only.

[FEATURE] Allow authentication via JWTs #40

Closed
jhoogstraat opened this issue May 23, 2020 · 4 comments
Closed

[FEATURE] Allow authentication via JWTs #40

jhoogstraat opened this issue May 23, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@jhoogstraat
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I'd like to authenticate a User via a JWT that contains a payload.

Describe the solution you'd like
Implement a JWTAuthGroup that authenticates a JWT and injects it into req.auth.
A CorvusJWTAuthenticator can be used to seperate the authentication from the group type.

@jhoogstraat jhoogstraat added the enhancement New feature or request label May 23, 2020
@jhoogstraat jhoogstraat mentioned this issue May 23, 2020
7 tasks
@jhoogstraat
Copy link
Contributor Author

Maybe this fits better in a separate package (like corvus-jwt) as this is not a core functionality and requires to have the jwt-kit and jwt dependencies from Vapor.

@bmikaili
Copy link
Contributor

Hmm, I'm not sure. I think if we want to go with a batteries-included approach, we can just include everything in Corvus, even if that makes the package size quite large. @PSchmiedmayer what do you think?

@PSchmiedmayer
Copy link
Contributor

@bmikaili @jhoogstraat I generally think that having everything in Corvus so far makes sense. One dependency that support all the functionality.
What about making it a separate target that is exported as a separate product? So you only have to import Corvus as a dependency but only if you include the target you have to build the JWT package. Then we also don't have to maintain two separate project and you can always test all the functionality in one repo 👍

@PSchmiedmayer
Copy link
Contributor

We will archive Corvus in favor of Apodini as a worthy successor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants