Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS support #106

Closed
benlevi1 opened this issue Oct 3, 2023 · 3 comments
Closed

HTTPS support #106

benlevi1 opened this issue Oct 3, 2023 · 3 comments

Comments

@benlevi1
Copy link

benlevi1 commented Oct 3, 2023

Hey folks,

First of all, I would like to thank you for an amazing library.
I am trying to work with a bitcoin instance via HTTPs (it is behind a gateway).
As far as I see, the client does not support the protocol: it does relate to "https" by adding the port 443 but there is no actual TLS handling.
Do you have any plans implementing it or is there any workaround?

@apoelstra
Copy link
Owner

We may add a minreq backend which has HTTPS support, and soft-deprecate our hand-rolled HTTP client (which seems to be subtly broken on certain platforms). The timeline for that is months, not weeks. Hopefully not years. I'm not sure who, if anybody, is actively working on it right now.

But we don't intend to implement HTTPS support ourselves.

@tcharding
Copy link
Collaborator

Adding HTTPS support by way of minreq shouldn't be too hard. I doubt it is that much work, for my part I don't like doing things unless I at least attempt to do them thoroughly and I have not found myself motivated enough by this work to do it thoroughly. I'm more than happy to review it if you feel like adding it @benlevi1, would be a useful addition to the crate IMO.

@tcharding
Copy link
Collaborator

minreq is implemented now and it provides HTTPS, this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants