Not compatible with the latest OpenWRT/luci release 18.06.0 #19
Comments
|
Experiencing the same issue with this theme. A quick look around and it appears a lot of classes have changed. |
|
ye, lot of things have changed and I'm still bound to https://github.com/domino-team/lede-ar300m, since there is still no support for the ar-300m. I know that darkmatter is popular and I'm rather unhappy that it's not working for you guys anymore but I don't have the time time to rework everything again for something that I can't even use on my hardware :/ |
|
Hey! thanks for the heads up. I'm considering doing the bulk of the work if I can get a hold of some documentation to help me. If you can point me in any sort of direction to make things easier I'd appreciate it. |
|
really not much to it: https://github.com/apollo-ng/luci-theme-darkmatter/blob/master/src/style.css "just" need to match up the classes again, sometimes there haven't been any in the html so you need to count elements or use other CSS/JS trickery to get a match, it's a big PITA and time consuming. I just used the browser DOM/CSS and did one page at a time in the browser to see how it looked and the put the changed CSS/JS into the files in src. |
|
Best thing I could dig up was this so far: https://github.com/openwrt/luci/wiki/Documentation |
|
hehe - ye, brute force it was. OpenWRTs 4MB flash size constraint weighs in heavily on freedom to theme. I've tried to bring it down as much as I could, but jquery takes its toll in size. The basic html coming from luci is not very theming friendly anyways, due to size constraints, dev legacy and only very few common classes/groups to keep a style consistent. When you factor in other opkgs which bring their own luci extension it gets even worse :) It would be great to get rid of jquery as well. |
|
I wish lede/openwrt folks would adopt this theme, it's that good! I'm reaming on an older build because of this. |
|
ヽ(´ー｀)ノ |
|
Are there any unofficial IPKs updates of this theme anywhere? I checked every fork available but they're all outdated. In the meantime I've taken a liking to the theme "Rosy", but Darkmatter would be nice. Right now it seems like the theme is abandonware though/will not update for latest release. In regards to a theme being officially adopted in the mainline OpenWrt release- the LEDE/OpenWrt folks won't adopt a theme unless the theme creator is willing to maintain it if there are any issues in the future, as was the catch for Rosy after reading some GitHub comments before they accepted it as they don't want to introduce a theme and then take on responsibility of updating it if it breaks or has issues with any devices/browsers/etc. |
|
+1 Please update |
|
@boktai1000 |
|
wanna send a PR? |
We can't really hope for that to happen since the openwrt crowd seems to have changed over the last couple of years and started to make it very hard for people to get anything in there and also offers no dialogue on how we could make UX things less archaic while still keeping the 4MB constraint for a lot of devices out there. I doubt there are many people who will promise "maintenance over many years to come" - which certainly is quite a commitment. Begging for inclusion AND having to promise maintenance WHILE having to deal with constant changes coming from upstream potentially breaking UX again and again is nothing I am willing to do. I'm just happy someone else picked it up and fixed it for now since there seem to be a lot of darkmatter installations out there and all would be happy to have it working with recent releases. Let's just keep it going like this, independent of the openwrt bubble. |
|
@chron0 PR send and extra work is necessary. |
|
@john-shine <3 - thank you, merged. |
|
@caesarw could you test if it works again pls? |
|
@chron0 yeah I'll do a test later. Thanks all your guys! |
|
Curious question I have- does this patch make it so the theme is compatible with versions both before and after 18.06, or is the theme now only compatible with 18.06 and beyond? Thanks! |
|
I wouldn't count on it, but I can't test since there is still (3y later) no nand openwrt for my gl.inets. If you have to deploy for <18 just use the commit before. |
|
@chron0 based on earlier comments I thought you were stuck on an older version and was mostly curious if these changes were backwards compatible with whatever you were running, as well as forward compatible with 18.06 and on. |
|
yeah, I'm stuck on old but since I can't use my hardware with that either (support for hardware interrupts has also been removed which I need for PPS) I'm currently not building new images for them. Thats technically the main factor why I haven't touched darkmatter for openwrt in a while. So I can't simply test and confirm either way :/ |
|
has anymore "fixed" this theme yet? I know I could update the styles file to update everything.. however that seems like a VERY time consuming thing to do! ;) Thanks |
|
yes, VERY - hence my personal reluctance to do this again every time - while the upstream crowd is bitching about bullshit. iirc @john-shine did an update not long ago, see above... |
thanks for the quick reply! It does seem like the latest release from @john-shine works! thanks! |
|
awesome, thanks for testing <3 |
|
@john-shine: is that one newer than the one in the last PR? If so, please send another PR so we can keep it up to date here as well. |
|
small amendment forget to PR, I had just send it. |
|
thanks for this nice work .. the last version has a bug where: |
The theme is not compatible with the latest version of OpenWRT and luci (18.06.0), which caused the Overview panel to be a mess (see screenshots below).
Any fixes on this?
Thanks!
The text was updated successfully, but these errors were encountered: