Added null check for response 'data' field before parsing payload #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gshcherb: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
apollographql#1215 According to https://facebook.github.io/graphql/draft/#sec-Data null data value is a valid value and can be present in the response
gshcherb
force-pushed
the
bugfix/null-data
branch
from
8b2051e
to
5fffba6
Compare
sav007
reviewed
Feb 25, 2019
| if (payload.containsKey("data")) { | ||
| Map<String, Object> buffer = (Map<String, Object>) payload.get("data"); | ||
| Map<String, Object> buffer = (Map<String, Object>) payload.get("data"); | ||
| if (buffer!=null) { |
There was a problem hiding this comment.
Am I missing smth but the changes are identical to what was before?
There was a problem hiding this comment.
Sorry my bad you are totally right.
Could you please add some tests as well?
There was a problem hiding this comment.
Added simple passing unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1215
According to https://facebook.github.io/graphql/draft/#sec-Data
null data value is a valid value and can be present in the response.