Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with fragment variables validation #1512

Merged
merged 2 commits into from Aug 20, 2019
Merged

Fix issue with fragment variables validation #1512

merged 2 commits into from Aug 20, 2019

Conversation

sav007
Copy link
Contributor

@sav007 sav007 commented Aug 20, 2019

  • Allow fragments to reference variables
  • Validate fragment variables
  • Improve variable, argument, directive validation reporting

@sav007
Fix issue with fragment variables validation
5a952ae 
- Allow fragments to reference variables
- Validate fragment variables
- Improve variable, argument, directive validation reporting
martinbonnin
martinbonnin approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all working 👍

@sav007 sav007 merged commit 894327f into apollographql:master Aug 20, 2019
@sav007 sav007 deleted the variable-validation-in-fragments branch August 20, 2019 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinbonnin martinbonnin martinbonnin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sav007 @martinbonnin