Introduce Kotlin Multiplatform into apollo-api module #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasomaniac
commented
Mar 10, 2020
apollo-api/src/commonMain/kotlin/com/apollographql/apollo/api/CustomTypeValue.kt
Show resolved
Hide resolved
tasomaniac
commented
Mar 10, 2020
apollo-api/src/commonMain/kotlin/com/apollographql/apollo/api/internal/SimpleResponseReader.kt
Show resolved
Hide resolved
tasomaniac
commented
Mar 10, 2020
apollo-api/src/jvmMain/kotlin/com/apollographql/apollo/api/ScalarType.kt
Show resolved
Hide resolved
sav007
reviewed
Mar 11, 2020
This reverts commit 1595070
sav007
reviewed
Mar 11, 2020
apollo-api/src/commonMain/kotlin/com/apollographql/apollo/api/BigDecimal.kt
Show resolved
Hide resolved
sav007
reviewed
Mar 11, 2020
apollo-api/src/commonMain/kotlin/com/apollographql/apollo/api/ScalarType.kt
Show resolved
Hide resolved
sav007
reviewed
Mar 11, 2020
sav007
reviewed
Mar 11, 2020
apollo-api/src/commonMain/kotlin/com/apollographql/apollo/api/ScalarTypeAdapters.kt
Show resolved
Hide resolved
|
This is awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, we only have
jvmas a target. That means that all changes in JVM should be backward compatible.What is next?
ScalarTypeAdaptersimplementations only exist in jvm. So in a potential native implementation, these need to be reimplemented.BigDecimalis typealiased tojava.math.BigDecimal. Investigation showed that usingULongin possible native impl should be enough.Optional, its siblings andUnmodifiableMapBuilderclasses are kept in Java and only ever going to be available for Java code generation. This should just work for now.Unit tests
Kept all tests in Java
(Checkstyle suddenly started to yell and had to little style fixes)In
apolli-apimodule, we only havejvmTesttarget. Once we have actual multi-platform code, this needs to be moved intocommonTestas much as possible.