Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate some normalized cache classes #2148

Merged
merged 4 commits into from Apr 9, 2020
Merged

Migrate some normalized cache classes #2148

merged 4 commits into from Apr 9, 2020

Conversation

tasomaniac
Copy link
Contributor

I had an overall look and started with most straight-forward ones.

@tasomaniac tasomaniac requested a review from sav007 April 7, 2020 21:47
@tasomaniac tasomaniac force-pushed the migrate-some-normalized-cache-classes branch from 6244790 to 09d0cad Compare April 8, 2020 19:25
sav007
sav007 approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@sav007 sav007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tasomaniac
Copy link
Contributor Author

ran japicmp, the changes are addition of Companion class, @metadata annotation and some functions becoming final. Nothing unexpected. Merging now.

@tasomaniac tasomaniac merged commit 7d5d1da into master Apr 9, 2020
@tasomaniac tasomaniac deleted the migrate-some-normalized-cache-classes branch April 9, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sav007 sav007 sav007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tasomaniac @sav007