Suppress raw type warning in generated code #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhuhaow: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
Is there a way to generate the fixture automatically? |
|
@zhuhaow there is but I always forget. The failed tests should give you the name of the flag in the failure message. |
|
It seems like a CI bug, it succeeded in my repo |
tasomaniac
approved these changes
Apr 10, 2020
|
Unfortunately, one Kotlin Multiplatform test is flaky. I re-run the job. Let's see now. Thanks a lot for the contribution 🎉 |
tasomaniac
pushed a commit
that referenced
this pull request
Apr 17, 2020
Co-authored-by: Zhuhao Wang <zhuhaow@zhuhaow-macbookpro2.roam.corp.google.com> (cherry picked from commit 6444002)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1895