-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aot, npm5): resolve AOT issues, add compatibility with npm5 #364
Conversation
CaerusKaru
commented
Sep 23, 2017
•
edited
Loading
edited
- Add Inject token to the Apollo class constructor to resolve AOT
- Expose types in index.ts
- Fixes bug(aot): warning compiling with AOT in angular v5 #363
- Fixes Problem with AOT #340
- Closes Expose ClientMap, ClientMapWrapper, ClientWrapper #360
- Closes chore(build): add support for npm5 git installation #362
@CaerusKaru: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
I just checked if the recent changes (master branch) allow to use I published it as Does my release works for you too? |
@kamilkisiela The latest release does not resolve #363. That specific problem was fixed in this PR by 8ce4285 |
@CaerusKaru Example app with AoT, Angular 5 and the https://github.com/kamilkisiela/apollo-angular-reproduction/tree/aot-5.0.0
|
@kamilkisiela On fresh install, I get the exact same warning as in #363:
Again, this is resolved in this PR |
Thanks! |
Many thanks! when will this change be added to the npm apollo-angular? Will it be 13.2? |
You can install these today with: |