Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aot, npm5): resolve AOT issues, add compatibility with npm5 #364

Merged
merged 4 commits into from
Sep 23, 2017

Conversation

CaerusKaru
Copy link
Contributor

@CaerusKaru CaerusKaru commented Sep 23, 2017

@apollo-cla
Copy link

@CaerusKaru: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@kamilkisiela
Copy link
Owner

kamilkisiela commented Sep 23, 2017

I just checked if the recent changes (master branch) allow to use apollo-angular with Angular 5's AoT. It seems that it works fine.

I published it as kamilkisiela-apollo-angular and not under apollo-angular to make more tests.

Does my release works for you too?

@CaerusKaru
Copy link
Contributor Author

CaerusKaru commented Sep 23, 2017

@kamilkisiela The latest release does not resolve #363. That specific problem was fixed in this PR by 8ce4285

@kamilkisiela
Copy link
Owner

kamilkisiela commented Sep 23, 2017

@CaerusKaru Example app with AoT, Angular 5 and the master branch of apollo-angular published as kamilkisiela-apollo-angular

https://github.com/kamilkisiela/apollo-angular-reproduction/tree/aot-5.0.0

npm i
npm run start:aot

@CaerusKaru
Copy link
Contributor Author

CaerusKaru commented Sep 23, 2017

@kamilkisiela On fresh install, I get the exact same warning as in #363:

Warning: Can't resolve all parameters for Apollo in /Users/main/apollo-angular-reproduction/node_modules/kamilkisiela-apollo-angular/Apollo.d.ts: (?). This will become an error in Angular v5.x

Again, this is resolved in this PR

@kamilkisiela kamilkisiela merged commit c698c99 into kamilkisiela:master Sep 23, 2017
@kamilkisiela
Copy link
Owner

Thanks!

@CaerusKaru CaerusKaru deleted the aot branch September 23, 2017 20:58
@3nd
Copy link

3nd commented Oct 2, 2017

Many thanks! when will this change be added to the npm apollo-angular? Will it be 13.2?

@intellix
Copy link
Contributor

intellix commented Oct 5, 2017

You can install these today with: npm i github:apollographql/apollo-angular if you're desperate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(aot): warning compiling with AOT in angular v5 Problem with AOT
5 participants