Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: BatchMaxQueries #1654

Closed
happylinks opened this issue May 4, 2017 · 4 comments
Closed

Feature request: BatchMaxQueries #1654

happylinks opened this issue May 4, 2017 · 4 comments

Comments

@happylinks
Copy link
Contributor

I just set up the batching queries with Apollo, which are great!
One thing I found was that when you execute a lot of mutations at the same time (let's say I want to save 100 images with a mutation for each), it will put all these queries in one batch.

This makes sense of course, because they are within the batch time limit. But a call with 100 mutations is probably slower then 10 calls with 10 queries.

My request would be to set a max for the amount of queries that are put into a batch. And if the batch is bigger then the max, start a new HTTP request.
This max could be set the same way as the batchInterval.

Would love to hear your thoughts :)

@helfer
Copy link
Contributor

helfer commented May 4, 2017

@happylinks I like the idea, it seems pretty reasonable to me! If you make a PR, I'd be happy to review it. 🙂

@helfer helfer added the feature label May 4, 2017
@happylinks
Copy link
Contributor Author

Cool, I'll take a stab at it :)

@happylinks happylinks mentioned this issue May 5, 2017
7 tasks
@stale
Copy link

stale bot commented Jul 15, 2017

This issue has been automatically marked as stale becuase it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions to Apollo Client!

@stale stale bot closed this as completed Jul 29, 2017
@stale
Copy link

stale bot commented Jul 29, 2017

This issue has been automatically closed because it has not had recent activity after being marked as stale. If you belive this issue is still a problem or should be reopened, please reopen it! Thank you for your contributions to Apollo Client!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants