Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data reducer requires queries and mutations to be passed in #370

Closed
Slava opened this issue Jul 8, 2016 · 5 comments
Closed

Data reducer requires queries and mutations to be passed in #370

Slava opened this issue Jul 8, 2016 · 5 comments
Assignees
Milestone

Comments

@Slava
Copy link
Contributor

Slava commented Jul 8, 2016

Right now the data reducer requires mutations and queries to be passed in because the information in the APOLLO_MUTATION/QUERY_RESULT action is not enough to apply a change.

Instead, we should make actions fatter and pass in all the necessary info. After that we should stop passing in mutations and queries into the data reducer.

@abhiaiyer91
Copy link
Contributor

I agree actions should hold more info, which is a very redux like approach. It'll also be more flexible.

@stubailo
Copy link
Contributor

Yep, I now realized that relying on all of that stuff already being in the store was a mistake.

@stubailo
Copy link
Contributor

If anyone is interested, this could be a relatively simple refactor to tackle.

@abhiaiyer91
Copy link
Contributor

Alright I'll make the changes

@amandajliu amandajliu self-assigned this Jul 18, 2016
@stubailo
Copy link
Contributor

Amanda's on it now.

@helfer helfer added this to the New API/Refactor milestone Sep 29, 2016
@helfer helfer modified the milestones: Post 0.5, Release 0.5 Oct 26, 2016
@helfer helfer closed this as completed Mar 28, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants