Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apollo-cache-inmemory please remove "src" folder #4083

Closed
tomitrescak opened this issue Nov 1, 2018 · 4 comments
Closed

apollo-cache-inmemory please remove "src" folder #4083

tomitrescak opened this issue Nov 1, 2018 · 4 comments
Assignees

Comments

@tomitrescak
Copy link

Hi, the "src" folder in the apollo-cache-inmemory is messing up jest tests. I'm pretty sure src is not necessary in the published package. Would you consider this? Thanks.

@benjamn benjamn self-assigned this Nov 16, 2018
@benjamn
Copy link
Member

benjamn commented Nov 16, 2018

It seems awfully silly that jest would concern itself with an unused directory in a package inside node_modules, but I suppose this is easy enough to fix.

@benjamn benjamn reopened this Nov 16, 2018
@benjamn
Copy link
Member

benjamn commented Nov 16, 2018

This should be fixed now with apollo-cache-inmemory@1.3.10.

@benjamn benjamn closed this as completed Nov 16, 2018
@tomitrescak
Copy link
Author

Thanks! Really appreciated. I know it’s silly, and I had to have some postinstall rimrafs happening;)

Thanks for the awesome package and work you’re doing.

@miamollie
Copy link

Thank you so much for fixing this, I've been going in circles with various jest issues and config settings changes but apollo-cache-inmemory@1.3.10 100% fixed it 👏

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants