Reset QueryInfo.diff and QueryInfo.dirty after canceling notify timeout #7696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut in markResult and markError
benjamn
approved these changes
Feb 14, 2021
benjamn
added a commit
that referenced
this pull request
Feb 14, 2021
This was referenced Mar 11, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7664. Previously, in #7347 we introduced
cancelNotifyTimeoutto prevent extra network requests. We still want to do this but we also need to resetQueryInfo.diffandQueryInfo.dirtyso future notify timeouts can be scheduled.Checklist: