Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useSubscription is missing context option #7824

Closed
toxeus opened this issue Mar 11, 2021 · 1 comment · Fixed by #7860
Closed

useSubscription is missing context option #7824

toxeus opened this issue Mar 11, 2021 · 1 comment · Fixed by #7860
Assignees
@jcreighton
Labels
⚛️ React-related
Projects
Release 3.4

Comments

@toxeus
Copy link

toxeus commented Mar 11, 2021

The useSubscription hook lacks the context option which is useful to drive Apollo Link. This is inconsistent with all the other hooks and seems to be an oversight. Please, consider also adding the context option to useSubscription.
@benjamn
Copy link
Member

benjamn commented Mar 11, 2021

@toxeus You're right, and this seems worthwhile to fix. We'll take a look!

@hwillson hwillson added this to the Release 3.4 milestone Mar 16, 2021
@hwillson hwillson added this to Planned in Release 3.4 Mar 16, 2021
@jcreighton jcreighton mentioned this issue Mar 18, 2021
Merged
2 tasks
@hwillson hwillson moved this from Planned to Done in Release 3.4 Mar 30, 2021
@brainkim brainkim assigned brainkim and unassigned brainkim Jun 22, 2021
@hwillson hwillson removed this from the MM-2021-06 milestone Jul 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jcreighton jcreighton

Labels
⚛️ React-related
Projects
No open projects
Release 3.4
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing context option to useSubscription apollographql/apollo-client
5 participants
@benjamn @hwillson @brainkim @jcreighton @toxeus