Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: @defer support #8184

Closed
hwillson opened this issue May 10, 2021 · 14 comments
Closed

Feature: @defer support #8184

hwillson opened this issue May 10, 2021 · 14 comments

Comments

@hwillson
Copy link
Member

hwillson commented May 10, 2021

This issue will be used to track our progress on adding @defer (not @stream) support to @apollo/client.

Related to:

@maraisr
Copy link

maraisr commented May 10, 2021

From a transport perspective meros is a great place to start to get the multipart fetching aspect fast and easy! Let me know however if you do decide to use this, but isnt 100% your api. Happy to have a chat.

@hwillson hwillson modified the milestones: Release 4.0, v4-defer, v4.0 - June 2021, v3.4 - June 2021 Jun 9, 2021
@hwillson hwillson modified the milestones: June 2021, July 2021, August 2021 Jul 6, 2021
@hwillson hwillson removed this from the MM-2021-08 milestone Jul 29, 2021
@hwillson hwillson added 2021-09 and removed 2021-08 labels Aug 17, 2021
@hwillson hwillson added 2021-10 and removed 2021-09 labels Sep 14, 2021
@hwillson hwillson removed this from In progress in Release 4.0 Oct 12, 2021
@hwillson hwillson added this to the Release 3.6 milestone Oct 12, 2021
@joelzwarrington
Copy link

@hwillson have noticed that @defer support has been bouncing around release milestones and what-not.

Is there anything that can be done to assist with this functionality?

Would really love to see this functionality, and don't want to have to use a fork to get that.

@maraisr
Copy link

maraisr commented Oct 13, 2021

@hwillson have noticed that @defer support has been bouncing around release milestones and what-not.

Is there anything that can be done to assist with this functionality?

Would really love to see this functionality, and don't want to have to use a fork to get that.

I kicked off the implication a few months back, but was told they'd be taking it on internally. Perhaps Apollo might be back to being open to a community contribution here, as ya 😅 think y'all seeing it as a back burner task?

@brainkim
Copy link
Contributor

brainkim commented Oct 14, 2021

It’s actually being worked on right now! I apologize for the delay. There were mitigating circumstances which led me to work on other things in the meantime 😓

Would really love to see this functionality, and don't want to have to use a fork to get that.

I’m personally always happy to see forks! It indicates that a codebase is relatively easy to understand and modify (this can not be said of the current repository).

I kicked off the [implementation] a few months back, but was told [Apollo would] be taking it on internally. Perhaps Apollo might be back to being open to a community contribution here, as [...] y'all [see] it as a back burner task?

It’s definitely not a back-burner task! We’ve tentatively committed to releasing it in 3.6, and our “second half” plans for the company seem to indicate @defer/@stream support will be widely available on all Apollo technologies by the end of the year, though of course, plans change. The thing is, it doesn’t seem @defer/@stream is going to be available in graphql-js@16, and we still haven’t really gotten around to implementing it in apollo-server (I’m using graphql-helix to test changes live).

I’m always happy for help. I personally think we as a company haven’t been as great about handling external contributions, despite the fact that... uhh... it would make our lives easier. @maraisr/@joelwarrington-jobber I’m happy to take calls about defer/stream whenever if you’d like to chat. Just send me an email!

@hwillson hwillson removed the 2021-11 label Nov 29, 2021
@dkogithub
Copy link

Hi @brainkim, do you have any news about it? Are you still working on it?
Can we have a hope to have it available in 3.6 release? We are really waiting for the @defer directive support by apollo-client :) Thanks in advance! :)

@hwillson hwillson added 2022-01 and removed 2021-12 labels Jan 3, 2022
@hwillson hwillson modified the milestones: Release 3.6, Release 3.7 Jan 6, 2022
@hwillson hwillson removed the 2022-01 label Jan 20, 2022
@hwillson hwillson removed this from the Release 3.7 milestone Jan 21, 2022
@extjbhlego
Copy link

@hwillson - The updates to the tags and this comment is a bit disheartening to be honest. Can you provide some insights to your expected new timeline for this?

@hwillson
Copy link
Member Author

@extjbhlego we'll have our @defer PR up for public review shortly.

@mauricedoepke
Copy link

@hwillson any updates on this?

@imranhassan87
Copy link

when can we expect this? any timeline?

@stewartmcgown
Copy link

You can follow along with their progress on this feature here: #9598

@jpvajda
Copy link
Contributor

jpvajda commented Sep 9, 2022

👋 @defer support is now available as a preview feature in Apollo Client 3.7. We have some preliminary documentation here. . You can use the beta version of our package on NPM to test.

@jpvajda jpvajda closed this as completed Sep 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.