Obfuscate Function(...) fallback to thwart static misanalysis
#9164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
changed the title
Function("return this") fallback to thwart static misanalysisFunction(...) fallback to thwart static misanalysis
benjamn
added
size/small
⏮ compatibility
brainkim
approved these changes
Dec 7, 2021
benjamn
deleted the
obfuscate-Function-fallback-to-thwart-static-misanalysis
branch
benjamn
restored the
obfuscate-Function-fallback-to-thwart-static-misanalysis
branch
benjamn
deleted the
obfuscate-Function-fallback-to-thwart-static-misanalysis
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR apollographql/invariant-packages#233 took care of
Function(...)usage within thets-invariant/processpackage, so this PR updatests-invariantto the latest version.Additionally, there was one similar bit of code using
Function(...)within the@apollo/clientpackage, so this PR cleans that up in way similar to thets-invariantchanges.Unless I'm mistaken about the cause of #9128 (static misanalysis reporting false positives), this PR should fix that issue.