-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking change in apollo-client.cjs.js #8592
Comments
@davixyz Could you import The |
We can adjust the imports as needed on our end; It's more of an issue in terms of NPM distributions; This might technically be a breaking change for all the clients consuming this file as the export changed and things were removed. Maybe restoring it as the initial stable version was is the way to go for sake of correctness and calling it out as deprecated so maybe gets removed as distributable in following versions (But please do leave a single big bundle for us using some older CommonJS bundlers) |
Intended outcome:
Have access to
ApolloProvider
exported fromapollo-client.cjs.js
yay provider
![Screen Shot 2021-08-05 at 12 03 23 PM](https://user-images.githubusercontent.com/4756314/128406766-9928ca0f-9e67-44bc-9202-28716a555ec6.png)
Actual outcome:
ApolloProvider
is no longer exported fromapollo-client.cjs.js
no provider to be found :(
![Screen Shot 2021-08-05 at 12 10 08 PM](https://user-images.githubusercontent.com/4756314/128407430-6d7b868f-6bde-419e-be32-8f090e9a1582.png)
How to reproduce the issue:
update to latest version and try to access Provider from apollo-client.cjs
Versions
"version": "3.4.5",
Note
For reasons we have to access Apollo through an entire CJS implementation; I realize that the provider is now in
react/react.cjs.js
but we were thinking thatapollo-client.cjs.js
would have the entire apollo client implementation in a single file.The text was updated successfully, but these errors were encountered: